Document how generated test cases are validated #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also simplify and clarify the related function's code
ghost
requested a review
from 
MaximilianAlgehed
approved these changes
Apr 5, 2024
quickcheck-dynamic/src/Test/QuickCheck/DynamicLogic/Internal.hs
Outdated
Show resolved
Hide resolved
Co-authored-by: Maximilian Algehed <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to understand the
Internals of q-d I was puzzled by theFalse ==> Falseexpression for a while and it's only by reading the definition of(==>)from QuickCheck that I realized this was a trick to discard a test case whose generation has been stuck. It seems to me clearer to make the discard explicit. Also simplified the related function's code as the first parameter was never used.Checklist: