Skip to content

Conversation

@curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Jun 4, 2025

Content

This PR includes aggregate_signature module covering StmAggrVerificationKey, StmAggregateSignature, StmClerk, and CoreVerifier.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #2369

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Test Results

    3 files  ±0     77 suites  ±0   16m 38s ⏱️ + 1m 49s
1 940 tests ±0  1 940 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 292 runs  ±0  3 292 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2480c3e. ± Comparison against base commit ca7cbd9.

This pull request removes 15 and adds 15 tests. Note that renamed tests count towards both.
mithril-stm ‑ stm::tests::batch_verify
mithril-stm ‑ stm::tests::test_adversary_quorum
mithril-stm ‑ stm::tests::test_aggregate_sig
mithril-stm ‑ stm::tests::test_core_verifier
mithril-stm ‑ stm::tests::test_dedup
mithril-stm ‑ stm::tests::test_initializer_serialize_deserialize
mithril-stm ‑ stm::tests::test_invalid_proof_index_bound
mithril-stm ‑ stm::tests::test_invalid_proof_index_unique
mithril-stm ‑ stm::tests::test_invalid_proof_path
mithril-stm ‑ stm::tests::test_invalid_proof_quorum
…
mithril-stm ‑ aggregate_signature::tests::batch_verify
mithril-stm ‑ aggregate_signature::tests::test_adversary_quorum
mithril-stm ‑ aggregate_signature::tests::test_aggregate_sig
mithril-stm ‑ aggregate_signature::tests::test_core_verifier
mithril-stm ‑ aggregate_signature::tests::test_dedup
mithril-stm ‑ aggregate_signature::tests::test_initializer_serialize_deserialize
mithril-stm ‑ aggregate_signature::tests::test_invalid_proof_index_bound
mithril-stm ‑ aggregate_signature::tests::test_invalid_proof_index_unique
mithril-stm ‑ aggregate_signature::tests::test_invalid_proof_path
mithril-stm ‑ aggregate_signature::tests::test_invalid_proof_quorum
…

♻️ This comment has been updated with latest results.

@curiecrypt curiecrypt temporarily deployed to testing-preview June 4, 2025 14:52 — with GitHub Actions Inactive
@curiecrypt curiecrypt requested a review from jpraynaud June 4, 2025 14:52
@curiecrypt curiecrypt marked this pull request as ready for review June 4, 2025 14:58
@curiecrypt curiecrypt force-pushed the curiecrypt/module-aggregate-signature branch from c755ee8 to 2480c3e Compare June 4, 2025 15:35
@curiecrypt curiecrypt requested a review from jpraynaud June 4, 2025 15:35
@curiecrypt curiecrypt temporarily deployed to testing-preview June 4, 2025 15:48 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curiecrypt curiecrypt merged commit 29be6f6 into main Jun 4, 2025
41 of 49 checks passed
@curiecrypt curiecrypt deleted the curiecrypt/module-aggregate-signature branch June 4, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants