Skip to content

feat(staking,common): [LW-8090] enable manageDelegation CTA from pool details #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2023
Merged

feat(staking,common): [LW-8090] enable manageDelegation CTA from pool details #720

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4cb75f
feat(staking,common): enable manageDelegation CTA from pool details
xdzurman Nov 9, 2023
650f28f
Merge branch 'main' into feat/LW-8090-Manage-delegation-button-from-S…
xdzurman Nov 10, 2023
38c1c3f
Merge remote-tracking branch 'upstream/main' into feat/LW-8090-Manage…
przemyslaw-wlodek Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/common/src/analytics/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export enum PostHogAction {
StakingBrowsePoolsStakePoolDetailStakeAllOnThisPoolClick = 'staking | browse pools | stake pool detail | stake all on this pool | click',
StakingBrowsePoolsStakePoolDetailAddStakingPoolClick = 'staking | browse pools | stake pool detail | add staking pool | click',
StakingBrowsePoolsStakePoolDetailUnselectPoolClick = 'staking | browse pools | stake pool detail | unselect pool | click',
StakingBrowsePoolsStakePoolDetailManageDelegation = 'staking | browse pools | stake pool detail | manage delegation | click',
StakingBrowsePoolsStakeClick = 'staking | browse pools | stake | click',
StakingBrowsePoolsUnselectClick = 'staking | browse pools | unselect | click',
StakingBrowsePoolsClearClick = 'staking | browse pools | clear | click',
Expand Down
25 changes: 16 additions & 9 deletions packages/staking/src/features/Drawer/StakePoolDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,12 @@ const makeActionButtons = (
): ActionButtonSpec[] =>
(
[
manageDelegation && {
callback: tmpNoop,
dataTestId: 'stake-pool-details-manage-delegation-btn',
label: t('drawer.details.manageDelegation'),
...getSpecOverride(manageDelegation),
},
stakeOnThisPool && {
callback: tmpNoop,
dataTestId: 'stake-pool-details-stake-btn',
Expand All @@ -233,12 +239,6 @@ const makeActionButtons = (
label: t('drawer.details.unselectPool'),
...getSpecOverride(unselectPool),
},
manageDelegation && {
callback: tmpNoop,
dataTestId: 'stake-pool-details-manage-delegation-btn',
label: t('drawer.details.manageDelegation'),
...getSpecOverride(manageDelegation),
},
] as (ActionButtonSpec | false)[]
).filter(Boolean) as ActionButtonSpec[];

Expand Down Expand Up @@ -291,13 +291,19 @@ export const StakePoolDetailFooter = ({ popupView }: StakePoolDetailFooterProps)
});
}, [viewedStakePool, analytics, portfolioMutators]);

const onManageDelegationClick = useCallback(() => {
if (!viewedStakePool) return;
analytics.sendEventToPostHog(PostHogAction.StakingBrowsePoolsStakePoolDetailManageDelegation);
portfolioMutators.executeCommand({
type: 'ManageDelegationFromDetails',
});
}, [viewedStakePool, analytics, portfolioMutators]);

const actionButtons = useMemo(
() =>
makeActionButtons(t, {
addStakingPool: ableToSelect && !selectionsEmpty && { callback: onSelectClick },
// TODO: disabling this button for now
// eslint-disable-next-line sonarjs/no-redundant-boolean
manageDelegation: false && poolInCurrentPortfolio,
manageDelegation: poolInCurrentPortfolio && { callback: onManageDelegationClick },
selectForMultiStaking: ableToSelect && selectionsEmpty && { callback: onSelectClick },
stakeOnThisPool: selectionsEmpty && ableToStakeOnlyOnThisPool && { callback: onStakeOnThisPool },
unselectPool: poolSelected && { callback: onUnselectClick },
Expand All @@ -306,6 +312,7 @@ export const StakePoolDetailFooter = ({ popupView }: StakePoolDetailFooterProps)
t,
ableToSelect,
selectionsEmpty,
onManageDelegationClick,
onSelectClick,
poolInCurrentPortfolio,
ableToStakeOnlyOnThisPool,
Expand Down
11 changes: 10 additions & 1 deletion packages/staking/src/features/store/delegationPortfolioStore/stateMachine/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ export type DrawerFailure = {
type: 'DrawerFailure';
};

export type ManageDelegationFromDetails = {
type: 'ManageDelegationFromDetails';
};

export type OverviewCommand = ShowDelegatedPoolDetails | ManagePortfolio | GoToBrowsePools;

export type BrowsePoolsCommand =
Expand All @@ -108,7 +112,12 @@ export type BrowsePoolsCommand =

export type CurrentPoolDetailsCommand = CancelDrawer;

export type PoolDetailsCommand = CancelDrawer | SelectPoolFromDetails | UnselectPoolFromDetails | BeginSingleStaking;
export type PoolDetailsCommand =
| CancelDrawer
| SelectPoolFromDetails
| UnselectPoolFromDetails
| BeginSingleStaking
| ManageDelegationFromDetails;

export type PortfolioManagementPreferencesCommand =
| CancelDrawer
Expand Down
10 changes: 10 additions & 0 deletions ...king/src/features/store/delegationPortfolioStore/stateMachine/processExpandedViewCases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
DrawerFailure,
GoToBrowsePools,
GoToOverview,
ManageDelegationFromDetails,
ManagePortfolio,
NewPortfolioConfirmationCommand,
NewPortfolioFailureCommand,
Expand Down Expand Up @@ -192,6 +193,15 @@ export const processExpandedViewCases: Handler = (params) =>
...atomicStateMutators.cancelDrawer({ state, targetFlow: DelegationFlow.BrowsePools }),
viewedStakePool: undefined,
})),
ManageDelegationFromDetails: handler<ManageDelegationFromDetails, StatePoolDetails, StatePortfolioManagement>(
({ state }) => ({
...state,
activeDelegationFlow: DelegationFlow.PortfolioManagement,
activeDrawerStep: DrawerManagementStep.Preferences,
draftPortfolio: currentPortfolioToDraft(state.currentPortfolio),
viewedStakePool: undefined,
})
),
SelectPoolFromDetails: handler<SelectPoolFromDetails, StatePoolDetails, StateBrowsePools>(
({ state, command: { data } }) => ({
...state,
Expand Down