feat: integrate lmp with v1 #2059
Conversation
Allure Report
processReports: ✅ test report for 1833d829
|
greatertomi
force-pushed
the
feat/lw-13671-v1-lmp-bundle
branch
from
06d68c4 to
2face67
Compare
|
|
||
| ## Creating an LMP Bundle Build | ||
| To create an LMP bundle for Lace: | ||
| - Place the LMP build at the repository root in `./lmp-build` |
There was a problem hiding this comment.
We should have scripts that do it. It can be achieved by adding lace-platform as git submodule/subrepo.
| - Place the LMP build at the repository root in `./lmp-build` |
There was a problem hiding this comment.
I started by adding lace-platform as a submodule/subrepo, but ran into several build issues. @pczeglik-iohk recommended we do a manual copy of the build from lace-platform for now, and that way we don't reveal any code from lace-platform since it is unreleased
There was a problem hiding this comment.
Can we do a manual git clone or symlink and have it gitignored?
There was a problem hiding this comment.
Can we manually copy entire lace-platform instead and move the build script to lace/apps/lmp-bundle?
There was a problem hiding this comment.
I tried the symlink approach, and I am having the same issue I have with submodules. I have to install some of lace-platform dependencies. Then there's a conflict with the typescript version.
There was a problem hiding this comment.
Please hoist all new files and npm scripts into a new app directory so that the changes are better isolated/encapsulated: apps/lmp-bundle
greatertomi
force-pushed
the
feat/lw-13671-v1-lmp-bundle
branch
from
2face67 to
a0dc5fc
Compare
|
|
||
| ## Creating an LMP Bundle Build | ||
| To create an LMP bundle for Lace: | ||
| - Place the LMP build at the repository root in `./lmp-build` |
There was a problem hiding this comment.
This is root readme, the path seems to be wrong. Please self-review and make sure it's cohesive.
| - Place the LMP build at the repository root in `./lmp-build` | |
| - Place the LMP build at the repository root in `./apps/lmp-bundle/lmp-build` |
There was a problem hiding this comment.
This README.md is within the apps/lmp-bundle directory. Do we need to specify the path from the root?
|
|
||
| ## Creating an LMP Bundle Build | ||
| To create an LMP bundle for Lace: | ||
| - Place the LMP build at the repository root in `./lmp-build` |
There was a problem hiding this comment.
Can we do a manual git clone or symlink and have it gitignored?
| To create an LMP bundle for Lace: | ||
| - Place the LMP build at the repository root in `./lmp-build` | ||
| - From the repository root run `yarn build:bundle:full` | ||
| - The command will produce a `.dist` file in the repository root. |
There was a problem hiding this comment.
Please make sure it's contained in the new app
| - The command will produce a `.dist` file in the repository root. | |
| - The command will produce a `apps/lmp-bundle/.dist` file in the repository root. |
| "watch:sw": "run -T webpack --config webpack.sw.dev.js --progress --watch", | ||
| "watch:project": "run-p watch:sw watch:app" | ||
| "watch:project": "run-p watch:sw watch:app", | ||
| "build:bundle:prepare": "yarn cleanup:dist && WEBPACK_PUBLIC_PATH=/sw/ yarn build:sw && WEBPACK_PUBLIC_PATH=/app/ yarn build:app && WEBPACK_PUBLIC_PATH=/app/ yarn build:cs" |
There was a problem hiding this comment.
Can we hoist this script to apps/lmp-bundle?
|
Checklist
Proposed solution
This creates an LMP build from Lace
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Screen.Recording.2025-11-18.at.00.mp4