Skip to content

LW-13680 Add FF_OVERRIDE env variable to locally override feature flags #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

LW-13680 Add FF_OVERRIDE env variable to locally override feature flags #2008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/browser-extension-wallet/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,3 +120,6 @@ SESSION_TIMEOUT=300000

# mempool.space api
MEMPOOLSPACE_URL=https://mempool.lw.iog.io

# Local feature flags override
FF_OVERRIDE='{"notifications-center": false}'
19 changes: 19 additions & 0 deletions apps/browser-extension-wallet/src/providers/PostHogClientProvider/client/PostHogClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ const isNetworkOfExpectedSchema = (n: string): n is NetworksEnumSchema => networ

const logger = contextLogger(commonLogger, 'PostHogClient');

const FALSY_VALUES = ['false', 'False', 'FALSE', 'f', 'F', '0', 0, false];
const TRUTHY_VALUES = ['true', 'True', 'TRUE', 't', 'T', '1', 1, true];
const VALID_VALUES = new Set([...FALSY_VALUES, ...TRUTHY_VALUES]);

/**
* PostHog API reference:
* https://posthog.com/docs/libraries/js
Expand All @@ -56,6 +60,7 @@ export class PostHogClient<Action extends string = string> {
hasPostHogInitialized$ = new BehaviorSubject(false);
featureFlagsByNetwork: FeatureFlagsByNetwork = featureFlagsByNetworkInitialValue;
featureFlagPayloads: FeatureFlagPayloads = featureFlagPayloadsInitialValue;
private ffOverride: Record<string, boolean> = {};

constructor(
private chain: Wallet.Cardano.ChainId,
Expand All @@ -66,6 +71,18 @@ export class PostHogClient<Action extends string = string> {
) {
if (!this.postHogHost) throw new Error('POSTHOG_HOST url has not been provided');
void this.initialize();

if (typeof process.env.FF_OVERRIDE === 'string')
try {
const ffOverride = JSON.parse(process.env.FF_OVERRIDE) as Record<string, string | number | boolean>;

for (const [key, value] of Object.entries(ffOverride)) {
if (VALID_VALUES.has(value)) this.ffOverride[key] = TRUTHY_VALUES.includes(value);
else commonLogger.error(`Invalid value for FF_OVERRIDE[${key}]: "${value}"`);
}
} catch (error) {
commonLogger.error('While parsing FF_OVERRIDE', error);
}
}

private async initialize() {
Expand Down Expand Up @@ -224,6 +241,8 @@ export class PostHogClient<Action extends string = string> {
}

isFeatureFlagEnabled(feature: FeatureFlag): boolean {
if (feature in this.ffOverride) return this.ffOverride[feature];

const currentNetworkFeatureFlags =
this.featureFlagsByNetwork[this.chain.networkMagic as Wallet.Cardano.NetworkMagics];
return currentNetworkFeatureFlags[feature] || false;
Expand Down
Loading