Skip to content

Conversation

@karknu
Copy link
Contributor

@karknu karknu commented May 21, 2025

description

Bring in the readFile fixes from new tracing subsystem.

The plain lazy readFile could cause cardano-node to leak file descriptors until it crashed.

checklist

  • compiles (cabal v2-build or stack build)
  • tests run successfully (cabal v2-test or stack test)
  • documentation added
  • link to an issue
  • add milestone (the current sprint)

@karknu karknu marked this pull request as ready for review May 22, 2025 05:39
@karknu karknu requested a review from erikd as a code owner May 22, 2025 05:39
Bring in the readFile fixes from new tracing subsystem.
@karknu karknu force-pushed the karknu/readFile_fixes branch from e633cf5 to 5ba7584 Compare May 22, 2025 05:40
Copy link

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @karknu !

Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erikd erikd added this pull request to the merge queue May 23, 2025
Merged via the queue into input-output-hk:master with commit dfce339 May 23, 2025
18 checks passed
@karknu karknu mentioned this pull request May 27, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants