Make it build with ghc 9.12 #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, ALWAYS import qualified and use a totally unabiguous qualified name, `Text`.
erikd
force-pushed
the
erikd/ghc-9.12
branch
7 times, most recently
from
9182e2e to
1c6abad
Compare
angerman
approved these changes
Mar 10, 2025
.github/workflows/haskell.yml
Outdated
| # Better to just disable it. | ||
| #- uses: actions/upload-artifact@v4 | ||
| # with: | ||
| # name: Build & test logs |
There was a problem hiding this comment.
I think you need override: true here. The semantics between v3 and v4 changed slightly. Iirc v3 did auto merge of artifacts under the same name. V4 doesn't.
erikd
force-pushed
the
erikd/ghc-9.12
branch
4 times, most recently
from
02fc152 to
faa9710
Compare
After switching from (depreacted) v3 to v4 it was broken and actually was not doing anything interesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
Make it build with ghc 9.12
checklist
cabal v2-buildorstack build)cabal v2-testorstack test)