Add various missing APIs to io-classes
#24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/io-classes
branch
4 times, most recently
from
de5daf1 to
014a6fc
Compare
Provide default implementations as part of `MonadSTM`, `MonadLabelledSTM` classes. Fixes IntersectMBO/ouroboros-network#3608
* `asyncBound` * `asyncOn` * `asyncOnWithUnmask` * `withAsyncBound` * `withAsyncOn` * `withAsyncWithUnmask` * `withAsyncOnWithUnmask` * `compareAsyncs`
Added: * `link2` * `link2Only` Fixes IntersectMBO/ouroboros-network#2650
coot
force-pushed
the
coot/io-classes
branch
from
014a6fc to
2a12e92
Compare
|
It's probably not a bad idea to split the
To make the transition simpler let's expose class (MonadSTM.MonadSTM m, MonadTVar m, MonadMVar m, ...) => MonadSTM m where {}There should also be a |
coot
force-pushed
the
coot/io-classes
branch
from
599374d to
bcd51b0
Compare
coot
force-pushed
the
coot/io-classes
branch
from
bcd51b0 to
363f8a0
Compare
bolt12
approved these changes
Sep 26, 2022
Removed the redundant proxy argument.
coot
force-pushed
the
coot/io-classes
branch
from
6de0b59 to
de6a292
Compare
coot
force-pushed
the
coot/io-classes
branch
from
187b5b7 to
38ee595
Compare
Follow a similar module structure as the "stm" package.
coot
force-pushed
the
coot/io-classes
branch
2 times, most recently
from
de05e75 to
f7e6406
Compare
Added missing: * flushTBQueue
`TSem` is already strict, so we just reexport the `Control.Concurrent.Class.MonadSTM.TSem` module.
castStrictTArray is not possible with ghc
We need to wait for the next release of "cborg" package.
Need to rebuild `typed-protocols` inside `dist-newstyle`.
Use the `fd` command in a way which allows to match relative paths and exclude files by relative path.
coot
force-pushed
the
coot/io-classes
branch
from
f7e6406 to
2316349
Compare
9 tasks
iohk-bors bot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Oct 6, 2022
4047: Use newer version of io-sim r=coot a=coot # Description Update to newer version of `io-sim` (see input-output-hk/io-sim#24). Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves IntersectMBO/ouroboros-network#2797
resolves IntersectMBO/ouroboros-network#2650
resolves IntersectMBO/ouroboros-network#3436
resolves IntersectMBO/ouroboros-network#2588
resolves IntersectMBO/ouroboros-network#2587
resolves IntersectMBO/ouroboros-network#2586
TODO:
StrictTArrayStrictTSemTSemis already strict, there's no need to provide a wrapper.StrictTChanflashTQueuelabelTChan&labelTChanIOtraceTChan&traceTChanIOcastStrictTQueue/castStrictTBQueue(and a likes)