Minor tweaks to tryReadTBQueueDefault
#222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
force-pushed
the
amesgen/tryReadTBQueueDefault
branch
from
40f3996 to
3a2d2e1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR makes minor improvements to the tryReadTBQueueDefault function implementations across the codebase. The changes address performance optimization and remove misleading documentation.
- Removes a misleading comment about laziness in the io-sim implementation
- Optimizes the io-classes implementation to avoid unnecessary
reverseoperations when the queue is empty - Updates changelog entries to document these improvements
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| io-sim/src/Control/Monad/IOSim/STM.hs | Removes misleading comment about lazy pattern matching |
| io-sim/CHANGELOG.md | Documents the removal of the misleading comment |
| io-classes/src/Control/Monad/Class/MonadSTM/Internal.hs | Optimizes empty queue check to avoid unnecessary reverse operation |
| io-classes/CHANGELOG.md | Documents the performance improvement |
coot
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit closes #197 as per #197 (comment)
The second commit fixes laziness in another implementation of
tryReadTBQueueDefaultinio-classes. I think this particulartryReadTBQueueDefaultisn't actually used anywhere though (unless someone implementsMonadSTMmanually for a new monad), but still seems easy enough to fix.