CAD-4738 stm monad catch instance

[yogeshsajanikar]

Based on the branch "CAD-4750-generalise-orelse-frame", this commit introduces Catch frame handler. It also adds Catch term in the reference STM for testing.

Resolves IntersectMBO/ouroboros-network#1461

[amesgen]

Looks great, always cool to see when things get simpler over time 🎉

I only have a few minor comments below. As before, I did not commented on the IOSimPOR part as it is identical.

[nfrisby]

I'll request some changes, just since I hope Yogesh finds a sufficiently lightweight way to address a couple of the eg testing comments. Nice stuff!

[coot]

It's on my todo list to review the PR... However, could you update ouroboros-network and check if all nightly tests are passing: for that one needs to add this snippet to cabal.project.local file:

package ouroboros-network-testing
  flags: -nightly

And then run:

cabal run ouroboros-netowrk-framework:test && cabal run ouroboros-network:test

[yogeshsajanikar]

@coot Running the nightly tests now. I will update the results here soon.

[yogeshsajanikar]

@coot The tests that you mentioned pass!

Running tests in ouroboros-network with io-sim commit id 9d2e67f

cabal run ouroboros-network-framework:test -> All 47 tests passed (118.51s)
cabal run ouroboros-network:test -> All 314 tests passed (480.21s)

[coot]

Very nice, just a few remarks.

[nfrisby]

One last round of minor comment adjustments! 👍

[nfrisby]

I'm Requesting Changes one last time! I only caught spelling/grammar this time, but one of the typos is important.

Code looks great!

[yogeshsajanikar]

#16 (comment) is being addressed here. #35. So now the catch term in this code drop is Catch :: Term t -> Term t -> Term t. The #35 handles exception. It also adds another exception type so that an exception can bubble up if the exception type is not handled. It is a WIP.

[nfrisby]

All the comments have been addressed 👍

Except for the new one I'm opening right now---looks like this commit undoes a recently merged PR. That's why I'm Requesting Changes one last time.

[nfrisby]

The diff looks minimal again. 🙌

Approved! Nice work 👍