docs: Fix mistake in cabal instructions and update stack-to-nix usage #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It changed in input-output-hk/nix-tools#29. Closes #72
angerman
approved these changes
Feb 26, 2019
rvl
changed the title
qrilka
reviewed
Feb 27, 2019
| { pkgs ? import <nixpkgs> {} }: | ||
|
|
||
| let | ||
| haskell = import (builtins.fetchTarball https://github.com/input-output-hk/haskell.nix/archive/master.tar.gz) { inherit pkgs; }; |
There was a problem hiding this comment.
doesn't this contradict with overrideWith described in basic user guide?
There was a problem hiding this comment.
Yes, actually we need update cabal-to-nix code generation to be more similar to stack-to-nix, and delete those big chunks of boilerplate code in the Setup section.
There was a problem hiding this comment.
And the proper way to override is with hackageSourceJSON and stackageSourceJSON? If so shouldn't they appear here?
There was a problem hiding this comment.
There should be a section in the user guide for pinning and overriding pins. But for now, #77.
andreabedini
pushed a commit
to andreabedini/haskell.nix
that referenced
this pull request
Sep 14, 2022
* Fix buildkite issues * Use default nixpkgs truncateIndex test. Update hash
andreabedini
pushed a commit
to andreabedini/haskell.nix
that referenced
this pull request
Sep 14, 2022
* Fix buildkite issues * Use default nixpkgs truncateIndex test. Update hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68