Skip to content

Fix missing -lnuma when linking musl test exes #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 5, 2020
Merged

Fix missing -lnuma when linking musl test exes #652

merged 4 commits into from
Jun 5, 2020

Conversation

hamishmack
Copy link
Collaborator

No description provided.

@hamishmack hamishmack requested a review from angerman June 4, 2020 14:24
angerman
angerman approved these changes Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

This will get even better with #628

@hamishmack hamishmack merged commit 6dc93ce into master Jun 5, 2020
@iohk-bors iohk-bors bot deleted the hkm/musl-numa branch June 5, 2020 00:54
booniepepper pushed a commit to booniepepper/haskell.nix that referenced this pull request Feb 4, 2022
@hamishmack @booniepepper
Fix missing -lnuma when linking musl test exes (input-output-hk#652)
1375800 
Also:

* Reduce the number of calls to override functions

* cp -L is not needed for user to cp calculateNoHash

* Update dummy-ghc files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishmack @angerman