wasm: disable tail-call flag for now #2440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported and confirmed from a ghc wasm backend user, tail-call opcodes may cause ios webview crashes for some large haskell wasm apps, and removing tail-call opcodes fixes the crash. Given webkit only supported tail-call since 18.2, it's better to disable tail-call flag for the time being and revisit this in the future. This patch also removes --no-turbo-fast-api-calls from the dyld script flags, since it was used to workaround nodejs/node#46777 when wasm module uses tail calls. It's not needed when tail calls are not used and it has a performance penalty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported and confirmed from a ghc wasm backend user (@maralorn), tail-call opcodes may cause ios webview crashes for some large haskell wasm apps, and removing tail-call opcodes fixes the crash. Given webkit only supported tail-call since 18.2, it's better to disable tail-call flag for the time being and revisit this in the future.
This patch also removes --no-turbo-fast-api-calls from the dyld script flags, since it was used to workaround
nodejs/node#46777 when wasm module uses tail calls. It's not needed when tail calls are not used and it has a performance penalty.