-
Notifications
You must be signed in to change notification settings - Fork 298
[DDW-60] V2 -> V3 wallet migration #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nikolaglumac
merged 11 commits into
v2-integration
from
feature/ddw-60-wallet-migration
Mar 26, 2020
Merged
[DDW-60] V2 -> V3 wallet migration #1905
nikolaglumac
merged 11 commits into
v2-integration
from
feature/ddw-60-wallet-migration
Mar 26, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomislavhoracek
approved these changes
Mar 26, 2020
Collaborator
tomislavhoracek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikolaglumac incredible, pure perfection 🎉 🚀 💯
12 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements wallet migration from current Daedalus mainnet into Byron Reboot Daedalus.
Todos
export-walletsfor the correct platformAdd test coverage- To be added in a separate taskScreenshots
Testing Checklist
Review Checklist
Basics
feature/bug/chore,release-x.x.x)yarn test)yarn dev)yarn package/ CI builds)yarn flow:test)yarn lint)yarn prettier:check)yarn manage:translationsproduces no changes)yarn storybook)yarn.lockfile is updatedCode Quality
Testing
After Review
donecolumn on the YouTrack board