Skip to content

Conversation

@nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Mar 25, 2020

This PR implements wallet migration from current Daedalus mainnet into Byron Reboot Daedalus.

Todos

  • Wait for Daedalus to connect to network
  • Execute export-wallets for the correct platform
  • Capture standard output and pare is to JS object
  • Capture error output to check for errors
  • Call wallet restoration from xPriv API for each wallet
  • Generate wallet migration report
  • Add test coverage - To be added in a separate task
  • Remove testing data

Screenshots

  • TBD

Testing Checklist


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@nikolaglumac nikolaglumac removed the WIP label Mar 26, 2020
@nikolaglumac nikolaglumac requested a review from topseniors March 26, 2020 15:57
Copy link
Collaborator

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikolaglumac incredible, pure perfection 🎉 🚀 💯

@nikolaglumac nikolaglumac merged commit 86950e7 into v2-integration Mar 26, 2020
@iohk-bors iohk-bors bot deleted the feature/ddw-60-wallet-migration branch March 26, 2020 16:12
@nikolaglumac nikolaglumac added release-1.0.0-FC1 Daedalus Flight and removed ⏳release-vNext labels Apr 1, 2020
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
@disassembler disassembler restored the feature/ddw-60-wallet-migration branch February 17, 2021 02:31
@disassembler disassembler deleted the feature/ddw-60-wallet-migration branch February 17, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants