Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Disable console when update is running #333

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Disable console when update is running #333

merged 1 commit into from
Oct 25, 2019

Conversation

HirotoShioi
Copy link
Contributor

ksaric
ksaric suggested changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert the space changes?
It was probably done by some formatting tools.

@HirotoShioi HirotoShioi force-pushed the hiroto/disable-console-on-update branch from 20ab8e0 to d97b6d0 Compare October 25, 2019 01:58
@HirotoShioi HirotoShioi force-pushed the hiroto/disable-console-on-update branch from d97b6d0 to 874daab Compare October 25, 2019 02:03
ksaric
ksaric approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ksaric ksaric merged commit b0da31e into master Oct 25, 2019
@ksaric ksaric deleted the hiroto/disable-console-on-update branch October 25, 2019 06:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ksaric ksaric ksaric approved these changes

@erikd erikd Awaiting requested review from erikd erikd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HirotoShioi @ksaric