Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

automatically disable tls if no path is configured #321

Merged
merged 1 commit into from
Oct 18, 2019
Merged

automatically disable tls if no path is configured #321

merged 1 commit into from
Oct 18, 2019

Conversation

cleverca22
Copy link
Contributor

@cleverca22 cleverca22 commented Oct 16, 2019 •
edited
Loading

solves #328

ksaric
ksaric suggested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is ok, but if we need this, we could simply add a CLI for it which we can use here.
Otherwise this is confusing.
Hiroto or I could add it if the story about TLS is not resolved quickly...

@cleverca22 cleverca22 added the wip Work In Progress label Oct 17, 2019
@cleverca22 cleverca22 force-pushed the disable-tls branch 2 times, most recently from bc50f45 to b8b0714 Compare October 18, 2019 00:18
@HirotoShioi
Copy link
Contributor

HirotoShioi commented Oct 18, 2019 •
edited
Loading

Please create an issue for this so we can understand what this solves.

@cleverca22 cleverca22 changed the title temporarily disable tls automatically disable tls if no path is configured Oct 18, 2019
ksaric
ksaric approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is better.

@cleverca22 cleverca22 removed the wip Work In Progress label Oct 18, 2019
@cleverca22 cleverca22 merged commit 8abae42 into master Oct 18, 2019
@cleverca22 cleverca22 deleted the disable-tls branch October 18, 2019 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ksaric ksaric ksaric approved these changes

@disassembler disassembler Awaiting requested review from disassembler

@HirotoShioi HirotoShioi Awaiting requested review from HirotoShioi

@erikd erikd Awaiting requested review from erikd erikd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cleverca22 @HirotoShioi @ksaric