ADP-1858-upgrade-from-csl-to-cml

[AngelCastilloB]

Context

The CSL was compiled to WASM using an old version of rustwasm which had a bug that would leak stack space when errors were thrown by the underlying rust library, This was making the CSL WASM module to crash after a several errors were thrown, this was fixed in later versions. The CML library uses the updated rustwasm and as such doesnt have this bug.

Proposed Solution

Reemplace the CSL library with the CML library

[rhyslbw]

I had a heart-in-mouth moment 😆:

Did you run npm i? Please ensure yarn install has been run again after removing the package-lock.json

[AngelCastilloB]

I had a heart-in-mouth moment 😆:

Did you run npm i? Please ensure yarn install has been run again after removing the package-lock.json

addressed here: c5cf29f

[rhyslbw]

The complete diff looks good, but there's a few distinct changes that have been lumped into a single commit, that need to be separated. I've commented on the ones that stick out to me, but it also appears that we missed including some CSL objects in the managed scope the first time around, so they would be best committed first as fix, then the lib replacement can be clean. If the new lib introduces new objects, then that's naturally part of the refactor commit.

[AngelCastilloB]

The complete diff looks good, but there's a few distinct changes that have been lumped into a single commit, that need to be separated. I've commented on the ones that stick out to me, but it also appears that we missed including some CSL objects in the managed scope the first time around, so they would be best committed first as fix, then the lib replacement can be clean. If the new lib introduces new objects, then that's naturally part of the refactor commit.

I split the extra manage here: b01944c

There are several new .manage calls, but is because now some of the functions that used to return just a number or a byte array now return an object, so those must be manage

[rhyslbw]

Some Spanglish? 😄

reemplaced -> replaced

[rhyslbw]

I split the extra manage here: b01944c

Great, that's good to see there was only a small number missed in the original implementation

[mkazlauskas]

Nice work!

[rhyslbw]

Great work @AngelCastilloB 👷