LW-12624: Fix output mapping on hardware wallets #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelCastilloB
changed the title
AngelCastilloB
changed the title
AngelCastilloB
commented
Apr 11, 2025
| * | ||
| * @param outputs The outputs to be verified. | ||
| */ | ||
| hasBabbageOutput(outputs: Array<Serialization.TransactionOutput>): boolean { |
There was a problem hiding this comment.
We can probably make this a method on the TransactionBody class
There was a problem hiding this comment.
Good idea, it would deduplicate this
|
Failing test |
AngelCastilloB
force-pushed
the
fix/output-mapping-on-hardware-wallets
branch
from
a2b3c5c to
2135507
Compare
fixed in b20f328 |
mkazlauskas
approved these changes
Apr 11, 2025
AngelCastilloB
force-pushed
the
fix/output-mapping-on-hardware-wallets
branch
from
2135507 to
3de9a1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We had a round-trip issue in our hardware wallet output mappings. This PR introduces a change to check for the actual format on the raw CBOR and passes as as context to the type mappers
Proposed Solution
Analyze the raw CBOR to detect the output format and pass it as part of the transformation context.