Fix/reject prs without linux in esbuild #1615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernokl
force-pushed
the
fix/reject-prs-without-linux-in-esbuild
branch
from
b185f9e to
7d9ae95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Our build breaks if the last yarn install that updates the lock file was done on a non-x86_64-linux machine.
Unfortunately, .yarn/plugins/yarn-plugin-nixify.cjs then removes Linux-specific dependencies from yarn-project.nix, adding ARM64 Darwin-specific ones, and a Nix build can no longer succeed on Linux.
Proposed Solution
Reject PRs without @esbuild/linux-x64@npm in yarn-project.nix.