Add support for an externally provided HyperProcess #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelsgesang
force-pushed
the
external-hyperd-connection
branch
from
bc82f9e to
2bc1325
Compare
|
No clue which issue the linux build has with the formatting... On my local machine |
vogelsgesang
force-pushed
the
external-hyperd-connection
branch
from
2bc1325 to
b613f2d
Compare
|
Can you check #118 as well? I'm guessing some of the changes from this PR made their way in there |
It's possible a versioning thing. I would suggest trying |
vogelsgesang
force-pushed
the
external-hyperd-connection
branch
from
b613f2d to
14b37c8
Compare
|
Ok - the I don't understand how my code changes could have broken this. Are the CI jobs currently expected to pass? |
|
They should. The mypy config should ignore missing stubs from external dependencies - not sure why this would appear now. I can take a look in a few hours but should be unrelated to your PR
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Adrian Vogelsgesang <[email protected]>
Sent: Monday, February 8, 2021 12:04:47 PM
To: innobi/pantab <[email protected]>
Cc: will_ayd <[email protected]>; Comment <[email protected]>
Subject: Re: [innobi/pantab] Add support for an externally provided HyperProcess (#117)
Ok - the black issues were indeed resolved by installing the right version. Now, I am running into errors from mypy:
pantab/_tester.py:8: error: Cannot find implementation or library stub for module named 'pytest'
pantab/_hyper_util.py:4: error: Cannot find implementation or library stub for module named 'tableauhyperapi'
pantab/_compat.py:3: error: Cannot find implementation or library stub for module named 'pandas'
pantab/_types.py:4: error: Cannot find implementation or library stub for module named 'tableauhyperapi'
pantab/_writer.py:8: error: Cannot find implementation or library stub for module named 'numpy'
pantab/_writer.py:9: error: Cannot find implementation or library stub for module named 'pandas'
pantab/_writer.py:10: error: Cannot find implementation or library stub for module named 'tableauhyperapi'
pantab/_reader.py:6: error: Cannot find implementation or library stub for module named 'numpy'
pantab/_reader.py:7: error: Cannot find implementation or library stub for module named 'pandas'
pantab/_reader.py:8: error: Cannot find implementation or library stub for module named 'tableauhyperapi'
pantab/tests/test_writer.py:3: error: Cannot find implementation or library stub for module named 'numpy'
pantab/tests/test_writer.py:4: error: Cannot find implementation or library stub for module named 'pandas'
pantab/tests/test_writer.py:5: error: Cannot find implementation or library stub for module named 'pytest'
pantab/tests/test_writer.py:6: error: Cannot find implementation or library stub for module named 'tableauhyperapi'
pantab/tests/test_roundtrip.py:1: error: Cannot find implementation or library stub for module named 'numpy'
pantab/tests/test_roundtrip.py:2: error: Cannot find implementation or library stub for module named 'pandas'
pantab/tests/test_roundtrip.py:3: error: Cannot find implementation or library stub for module named 'pandas.testing'
pantab/tests/test_roundtrip.py:4: error: Cannot find implementation or library stub for module named 'tableauhyperapi'
pantab/tests/test_reader.py:1: error: Cannot find implementation or library stub for module named 'pandas'
pantab/tests/test_reader.py:2: error: Cannot find implementation or library stub for module named 'pandas.testing'
pantab/tests/test_reader.py:3: error: Cannot find implementation or library stub for module named 'pytest'
pantab/tests/test_reader.py:4: error: Cannot find implementation or library stub for module named 'tableauhyperapi'
pantab/tests/conftest.py:3: error: Cannot find implementation or library stub for module named 'numpy'
pantab/tests/conftest.py:3: note: See https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports
pantab/tests/conftest.py:4: error: Cannot find implementation or library stub for module named 'pandas'
pantab/tests/conftest.py:5: error: Cannot find implementation or library stub for module named 'pytest'
pantab/tests/conftest.py:6: error: Cannot find implementation or library stub for module named 'tableauhyperapi'
I don't understand how my code changes could have broken this. Are the CI jobs currently expected to pass?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#117 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAEU4UPXEDDDCJWNHZFMG6TS6A7V7ANCNFSM4XH6QF2A>.
|
|
Looks like the Mypy issue might just be a bug with the latest version: I'll push up a patch separately |
WillAyd
reviewed
Feb 8, 2021
vogelsgesang
force-pushed
the
external-hyperd-connection
branch
from
1c5702e to
0037b38
Compare
|
Hello @vogelsgesang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-09 00:02:05 UTC |
vogelsgesang
force-pushed
the
external-hyperd-connection
branch
from
0037b38 to
d19bf81
Compare
So far, pantab always internally created an adhoc `HyperProcess`. This commit allows users to instead spawn their own `HyperProcess` and pass it to pantab's functions through a `hyper` keyword argument. By providing their own `HyperProcess`, users * have full control over the start-up flags of `HyperProcess` and can, e.g., disable the creation of the `hyperd.log` log file. * reuse the same `HyperProcess` across multiple function calls and thereby save a few milliseconds per function invocation.
vogelsgesang
force-pushed
the
external-hyperd-connection
branch
from
d19bf81 to
7347cc7
Compare
|
should be ready to be merged now |
WillAyd
approved these changes
Feb 9, 2021
|
Thanks @vogelsgesang |
|
Any timeline when this will be released to pypi. |
|
There are still two pull requests in the pipeline (#123 and #128) which we probably want to merge before cutting a new release. Neither of those changes is a strict requirement before cutting a new release. But we would prefer to have them in the 2.0 release, since at least #123 is also an interface-breaking change. We prefer to bundle those interface-breaking changes into one release instead of having two subsequent interface-breaking changes, so we reduce the burden of upgrading the pantab dependency for down-stream users of pantab. Originally, we hoped to move #123 and #128 ahead much faster. Unfortunately, it took longer because I first had to get approval by my company to upstream those changes and this whole legal process took a while. But that's out of the way now, so I hope we will get those two changes merged within the next week or so. The final decision on when to release a new version is up to @WillAyd, though... |
|
@farhangithub27 pantab 2.0 was just released to pypi and this new version also comes with support for the externally provided HyperProcess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, pantab always internally created an adhoc
HyperProcess. Thiscommit allows users to instead spawn their own
HyperProcessand passit to pantab's functions through a
hyperkeyword argument.By providing their own
HyperProcess, usersHyperProcessand can,e.g., disable the creation of the
hyperd.loglog file.HyperProcessacross multiple function calls andthereby save a few milliseconds per function invocation.
closes #51, closes #39