-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Guidelines: https://petsymposium.org/artifacts.php
speed up docker build time
go
COPY go.mod go.sum ./
# Download dependencies
RUN go mod download
Unorganized list of tasks
- simplify the docker compose flow
- Control startup and shutdown order in Compose: https://docs.docker.com/compose/startup-order/
- Use healthcheck (https://docs.docker.com/compose/compose-file/#healthcheck) to check for condition before starting second node
- use docker compose instead of docker-compose (see notice at https://docs.docker.com/compose/)
- review and simplify Dockerfile -- for instance the base images use rocksdb, why?
- do we need to track hacking/backup_snip20?
- do we need to build secretcli, I think we don't
- API KEY & SPID is probably not needed
- is node/npm needed? it may be for the bootstrap node, for the
faucet.js
docker compose vs docker-compose
Given the deprecation notice and that we wish for the artifact to be usable as long as possible then the switch seems to be a well justified.
Important
From the end of June 2023 Compose V1 won’t be supported anymore and will be removed from all Docker Desktop versions.
Make sure you switch to Compose V2 with the docker compose CLI plugin or by activating the Use Docker Compose V2 setting in Docker Desktop. For more information, see the Evolution of Compose
Metadata
Metadata
Assignees
Labels
No labels