Skip to content

fix: estimation min set to gas_used - 1 rather than to estimate - 1 #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2025
Merged

fix: estimation min set to gas_used - 1 rather than to estimate - 1 #112

merged 3 commits into from
Jun 18, 2025

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Jun 18, 2025 •
edited
Loading

fixes gas estimation bug that would cause it to vastly overestimate

@prestwich Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@prestwich prestwich marked this pull request as ready for review June 18, 2025 15:44
Evalir
Evalir approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Evalir Evalir merged commit fc58b46 into main Jun 18, 2025
7 checks passed
@anna-carroll anna-carroll deleted the prestwich/fix-estimation-min branch June 18, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @Evalir