-
Notifications
You must be signed in to change notification settings - Fork 1
test: extend evil test suite #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the "evil" test suite to include comprehensive tests for filesystem operations and environment variable access within WASM components. The evil test suite is designed to verify security boundaries and proper sandboxing of WASM execution.
Key changes:
- Added environment variable tests to verify sandbox isolation (
env.rsmodules) - Added comprehensive filesystem operation tests covering read/write/permissions (
fs.rsmodules) - Extended root filesystem tests with invalid TAR entries, non-TAR content, and unsupported entry types
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
host/tests/integration_tests/evil/test_utils.rs |
Added try_scalar_udfs_with_env helper to support passing environment variables to evil tests |
host/tests/integration_tests/evil/env.rs |
New test module verifying environment variable access (args, current_dir, current_exe, env vars) |
host/tests/integration_tests/evil/fs.rs |
New test module with comprehensive filesystem operation tests (1065 lines) |
host/tests/integration_tests/evil/root.rs |
Added tests for invalid TAR entries, non-TAR content, and unsupported entry types |
host/tests/integration_tests/evil/mod.rs |
Registered new test modules |
host/tests/integration_tests/python/runtime/env.rs |
Updated to handle empty environment variables correctly |
guests/evil/src/env.rs |
New guest-side implementation of environment variable access UDFs |
guests/evil/src/fs.rs |
New guest-side implementation of filesystem operation UDFs |
guests/evil/src/root/invalid_entry.rs |
New evil payload with invalid TAR entry |
guests/evil/src/root/not_tar.rs |
New evil payload returning non-TAR bytes |
guests/evil/src/root/unsupported_entry.rs |
New evil payload with unsupported TAR entry type |
guests/evil/src/root/many_files.rs |
Updated to accept configurable limit via environment variable |
guests/evil/src/root/mod.rs |
Registered new root payload modules |
guests/evil/src/lib.rs |
Updated multiplexer to route to new evil payloads |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5b573ed to
27e037c
Compare
| } | ||
| } | ||
|
|
||
| impl ScalarUDFImpl for String1Udf { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing "UDF" vs "Udf" is a little jarring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair, I'll fix that repo-wide in a follow-up PR.
27e037c to
c013f26
Compare
Co-authored-by: Copilot <[email protected]>
c013f26 to
c1f2f9a
Compare
For #16.