Skip to content

Conversation

@Umekawa
Copy link
Member

@Umekawa Umekawa commented Oct 7, 2025

What

  • Calculate and upload code coverage data to qlty during CI
  • Make code coverage and Maintainability viewable from the README

How

  • Install simplecov_json_formatter
  • Change the coverage output format to JSON
  • Implement the coverage action from qlty
  • Add a badge to the README

Why

REF

@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 04:03
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@Umekawa Umekawa self-assigned this Oct 7, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Introduces integration with qlty to publish and display code coverage and maintainability metrics.

  • Adds JSON coverage formatter configuration via SimpleCov.
  • Adds qlty coverage upload job in GitHub Actions and corresponding badges to the README.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
spec/spec_helper.rb Adds MultiFormatter including JSON and HTML formatters for coverage output.
graphql-kaminari_connection.gemspec Adds simplecov_json_formatter as a development dependency.
README.md Adds Maintainability and Code Coverage badges from qlty.
.github/workflows/test.yml Adds a separate qlty job to run tests and upload coverage JSON.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Umekawa Umekawa requested a review from wataru86 October 8, 2025 00:53
Copy link
Member

@wataru86 wataru86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Umekawa Umekawa merged commit 23fe60a into master Oct 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants