Skip to content

Fixes #1023 - Load exceptions in user resolvers are not reported #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ljharb merged 1 commit into from
Feb 18, 2018
Merged

Fixes #1023 - Load exceptions in user resolvers are not reported #1024

ljharb merged 1 commit into from
Feb 18, 2018

Conversation

@patrick-steele-idem
Copy link
Contributor

@patrick-steele-idem patrick-steele-idem commented Feb 14, 2018 •
edited by ljharb
Loading

Put try...catch around require.resolve() (not require())

Fixes #1023.

@coveralls
Copy link

coveralls commented Feb 15, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 96.248% when pulling 8778d7c on patrick-steele-idem:issue-1023 into 91cfd6d on benmosher:master.

@ljharb ljharb merged commit 654d284 into import-js:master Feb 18, 2018
@ljharb ljharb mentioned this pull request Feb 18, 2018
Closed
@renovate renovate bot mentioned this pull request Feb 22, 2018
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 21, 2018
Closed
@renovate renovate bot mentioned this pull request Mar 22, 2018
Merged
This was referenced Aug 17, 2021
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 4, 2021
Open
@MaxMood96 MaxMood96 mentioned this pull request May 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 14, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request May 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Load exceptions in user resolvers are not reported

3 participants

@patrick-steele-idem @coveralls @ljharb