Skip to content

Conversation

oinoom
Copy link
Contributor

@oinoom oinoom commented Sep 19, 2025

Fixes a bug where LazyTokenStreams were not being properly ignored

@ahomescu ahomescu force-pushed the ahomescu/fix_reorganize_definitions branch from 3b6b204 to 0f281b4 Compare September 19, 2025 02:54
@ahomescu
Copy link
Contributor

This fixes the issue? Was a macro invocation also the problem in the transpiled code?

If the problem is LazyTokenStream, the problem might be that we're missing an attribute for the matcher for that node in https://github.com/immunant/c2rust/blob/ahomescu/restore_refactor/c2rust-refactor/gen/ast.txt#L590.

@oinoom oinoom requested a review from ahomescu September 19, 2025 14:01
@ahomescu ahomescu force-pushed the ahomescu/fix_reorganize_definitions branch 3 times, most recently from 6aa13a0 to 6d527b1 Compare October 7, 2025 22:46
@oinoom oinoom force-pushed the fix.literal_suffix.vec branch 3 times, most recently from 546a52b to d0ef71c Compare October 8, 2025 20:55
@ahomescu ahomescu force-pushed the ahomescu/fix_reorganize_definitions branch 4 times, most recently from cd518be to 9804b07 Compare October 8, 2025 23:20
@oinoom oinoom force-pushed the fix.literal_suffix.vec branch from d0ef71c to c2a682a Compare October 9, 2025 21:18
}
}

#[derive(Clone, Debug, Default)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this?

"mismatch between unexpanded and expanded ASTs \n old: {:?}\n new: {:?}",
old, new
),
(&None, &Some(ref new_val)) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this anymore?

@oinoom oinoom force-pushed the fix.literal_suffix.vec branch from 54d9bc6 to 708b0f4 Compare October 14, 2025 16:33
@oinoom oinoom changed the base branch from ahomescu/fix_reorganize_definitions to master October 14, 2025 16:35
@oinoom oinoom merged commit 9f28416 into master Oct 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants