feat: plugin release v1.0.0 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the initial v1.0.0 release of the ImageKit plugin for Sanity Studio V3, enabling seamless integration of ImageKit's media library for asset management.
Key Changes:
- Core plugin implementation with TypeScript support and full type definitions
- Two plugin exports:
imagekitSchemaPluginfor custom asset types andimagekitAssetSourcePluginfor standard image field integration - Full-screen modal dialog for ImageKit media library with dark mode support
Reviewed Changes
Copilot reviewed 18 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Project configuration with dependencies and metadata |
| tsconfig.lib.json | TypeScript compiler configuration for library build |
| src/index.ts | Main plugin exports and configuration |
| src/types/index.ts | Type definitions for ImageKit assets and responses |
| src/schema/imagekitAsset.ts | Schema definition for imagekit.asset type |
| src/utils.ts | Media selector modal implementation with theme support |
| src/components/*.tsx | React components for asset selection, preview, and diff views |
| README.md | Documentation for installation and usage |
| LICENSE | MIT license file |
| sanity.json | Sanity plugin metadata |
| package.config.ts | Sanity CLI configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+66
to
+78
| // return ( | ||
| // <Card padding={3} radius={2} shadow={1} tone="default"> | ||
| // <Box style={{textAlign: 'center'}}> | ||
| // <Icon style={{fontSize: '2rem', marginBottom: '0.5rem'}} /> | ||
| // <Text size={1} weight="semibold"> | ||
| // {value.name} | ||
| // </Text> | ||
| // <Text size={0} muted> | ||
| // {value.width} × {value.height} • {value.fileType} | ||
| // </Text> | ||
| // </Box> | ||
| // </Card> | ||
| // ) |
There was a problem hiding this comment.
Remove commented-out code. If this alternative implementation is no longer needed, it should be deleted to improve code clarity.
Suggested change
| // return ( | |
| // <Card padding={3} radius={2} shadow={1} tone="default"> | |
| // <Box style={{textAlign: 'center'}}> | |
| // <Icon style={{fontSize: '2rem', marginBottom: '0.5rem'}} /> | |
| // <Text size={1} weight="semibold"> | |
| // {value.name} | |
| // </Text> | |
| // <Text size={0} muted> | |
| // {value.width} × {value.height} • {value.fileType} | |
| // </Text> | |
| // </Box> | |
| // </Card> | |
| // ) |
Comment on lines
+7
to
+8
| // eslint-disable-next-line react/no-unused-prop-types | ||
| kind: PlayerKind |
There was a problem hiding this comment.
The 'kind' prop is defined but unused. Either remove it or implement its intended functionality. Using an eslint-disable comment to suppress the warning is not a proper solution.
…in sanity vs imagekit's data structures and their allowed keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.