Add String std::string wrapper and some methods to Serial mock. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I will use that! |
jonathanperret
pushed a commit
to jonathanperret/arduino-mock
that referenced
this pull request
Aug 25, 2024
Co-authored-by: stla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used your library for off device testing on googlesamples/firebase-arduino and thought I would push some of these changes upstream. Thanks for the work you did so far, made my life easier!
We use arduino String alot so I added a wrapper around std::string that replicates the parts of it we are using, also needed to add some methods to your mock Serial that use String.