Added a class to check the timings of cuda kernels, started using it in the RapidHeightMapExtractorCUDA #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the RapidHeightMapExtractorCUDA
…cleanup the usages
ds58
requested changes
Feb 18, 2025
| * This class handles the kernel timings. | ||
| * With options to compute the min/max, average, and variance of the dataset | ||
| */ | ||
| private static class CudaKernelTimings |
| { | ||
| private final CUfunc_st kernelFunction = new CUfunc_st(); | ||
| private final List<Pointer> parameters = new ArrayList<>(); | ||
| private final String name; |
Contributor
There was a problem hiding this comment.
Can you make this the first field above kernelFunction?
| private final CUevent_st end = new CUevent_st(); | ||
|
|
||
| private int error; | ||
| private boolean enableKernelTimings = false; |
Contributor
There was a problem hiding this comment.
Can you move this below retainParameters so that the "flags" of the class are together?
Comment on lines
125
to
133
| if (PRINT_TIMING_FOR_KERNELS) | ||
| { | ||
| updateKernel.enableKernelTimings(true); | ||
| registerKernel.enableKernelTimings(true); | ||
| croppingKernel.enableKernelTimings(true); | ||
| planOffsetKernel.enableKernelTimings(true); | ||
| emptyRegisterKernel.enableKernelTimings(true); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Just pass PRINT_TIMING_FOR_KERNELS into each method
e.g. updateKernel.enableKernelTimings(PRINT_TIMING_FOR_KERNELS);
|
|
||
| if (PRINT_TIMING_FOR_KERNELS) | ||
| { | ||
| snappingKernel.enableKernelTimings(true); |
Contributor
There was a problem hiding this comment.
snappingKernel.enableKernelTimings(PRINT_TIMING_FOR_KERNELS);
ds58
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.