Skip to content

Conversation

zyuyou
Copy link
Contributor

@zyuyou zyuyou commented Mar 29, 2023

  1. Add block before ERL_IMPORT_FUNCTIONS.
  2. Maybe Expr indent process.

@ShawnMcCool
Copy link

Hi there, I would love to see this merged so that I don't have an IDE mess with maybe_expr.

@zyuyou
Copy link
Contributor Author

zyuyou commented Apr 12, 2023

Hi there, I would love to see this merged so that I don't have an IDE mess with maybe_expr.

not really, maybe_expr has supported in IDEA-2023. and this patch just for indent format.

@kvakvs
Copy link
Collaborator

kvakvs commented Apr 22, 2023

I can't understand what does 1st change do? How to test it?
Please reset your master to ignatov:master and cherry-pick 70fdc3a and 1b49afa

@zyuyou
Copy link
Contributor Author

zyuyou commented May 4, 2023

Add block before ERL_IMPORT_FUNCTIONS.

Before:

-import(lists, [
reverse/1, 
keyreplace/4
]).

After:

-import(lists, [
    reverse/1, 
    keyreplace/4
]).

Maybe Expr indent process.

Before:

maybe
true ?= foo(),
    ok
else 
    false ->
        false
end,

After:

maybe
    true ?= foo(),
    ok
else 
    false ->
        false
end,

@kvakvs

@ignatov
Copy link
Owner

ignatov commented Jul 6, 2023

Thanks for the PR, could you please add some formatter tests?

@zyuyou
Copy link
Contributor Author

zyuyou commented Sep 13, 2023

Thanks for the PR, could you please add some formatter tests?

It's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants