Skip to content

Consider-none-equivalent-value-for-missing-data-pints-in-weather #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 56 commits into
base: dev
Choose a base branch
from
Draft

Consider-none-equivalent-value-for-missing-data-pints-in-weather #417

wants to merge 56 commits into from

Conversation

staudtMarius
Copy link
Member

Resolves #188

@staudtMarius staudtMarius added the enhancement New feature or request label Nov 29, 2022
@staudtMarius staudtMarius self-assigned this Nov 29, 2022
@staudtMarius staudtMarius marked this pull request as ready for review December 6, 2022 10:22
@sebastian-peter sebastian-peter added this to the Version 4.0 milestone Feb 17, 2023
staudtMarius and others added 19 commits August 14, 2023 15:51
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
367175d 
…ssing-data-pints-in-weather
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
4e68320 
…ssing-data-pints-in-weather
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
369d0d9 
…ssing-data-pints-in-weather

# Conflicts:
#	src/main/scala/edu/ie3/simona/ontology/messages/services/WeatherMessage.scala
#	src/main/scala/edu/ie3/simona/service/weather/WeatherSource.scala
#	src/test/scala/edu/ie3/simona/service/weather/WeatherSourceSpec.scala
@staudtMarius
Adapting to changes.
b8e68cd
@staudtMarius
Fixing Codacy issue.
e50c589
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
d9b55ba 
…ssing-data-pints-in-weather
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
4055ecb 
…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
03504ea 
…ssing-data-pints-in-weather
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
6fa3982 
…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md
@staudtMarius
Merge remote-tracking branch 'origin/ms/#188-consider-none-equivalent…
303e871 
…-value-for-missing-data-pints-in-weather' into ms/#188-consider-none-equivalent-value-for-missing-data-pints-in-weather
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
8ccb0e2 
…ssing-data-pints-in-weather
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
cfe1346 
…ssing-data-pints-in-weather
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
360223c 
…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md
@staudtMarius
Merge remote-tracking branch 'origin/ms/#188-consider-none-equivalent…
62503bf 
…-value-for-missing-data-pints-in-weather' into ms/#188-consider-none-equivalent-value-for-missing-data-pints-in-weather
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
54d0cd8 
…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
543d496 
…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/service/weather/WeatherSource.scala
@staudtMarius
Resolving merge conflicts.
395ea9d
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
c5db94c 
…ssing-data-pints-in-weather
@staudtMarius
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
981a3dd 
…ssing-data-pints-in-weather
danielfeismann
danielfeismann reviewed Jul 1, 2024
View reviewed changes
src/test/scala/edu/ie3/simona/service/weather/WeatherValueInterpolationSpec.scala Outdated
time,
intervalStart,
time,
"diffIrr"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be dirIrr?

src/test/scala/edu/ie3/simona/service/weather/WeatherValueInterpolationSpec.scala Outdated
time,
time,
intervalEnd,
"diffIrr"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@staudtMarius
Copy link
Member Author

@pierrepetersmeier

@pierrepetersmeier pierrepetersmeier self-assigned this Apr 11, 2025
@sebastian-peter sebastian-peter removed this from the Version 4.0 milestone Apr 17, 2025
@sebastian-peter
Moving ValueWithWeight to appropriate class
23e042f
@sebastian-peter
Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…
bc2a4de 
…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/service/weather/WeatherSource.scala
#	src/main/scala/edu/ie3/simona/service/weather/WeatherSourceWrapper.scala
@sebastian-peter
Merging quantity conversion
4459ca7
@sebastian-peter
Reverting unnecessary changes
850cdb7
@sebastian-peter sebastian-peter marked this pull request as draft September 2, 2025 14:50
@sebastian-peter
Copy link
Member

Note: We're currently discussing moving this functionality to PSDM instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann left review comments

@t-ober t-ober Awaiting requested review from t-ober

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

At least 1 approving review is required to merge this pull request.

Assignees

@staudtMarius staudtMarius

@pierrepetersmeier pierrepetersmeier

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider None-equivalent value for missing data points in weather
4 participants
@staudtMarius @sebastian-peter @danielfeismann @pierrepetersmeier