Skip to content

Adapt ThermalHouse and HP flexibility behaviour #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Sep 16, 2025
Merged

Adapt ThermalHouse and HP flexibility behaviour #1392

merged 44 commits into from
Sep 16, 2025

Conversation

@danielfeismann
Copy link
Member

resolves #1391

@danielfeismann danielfeismann self-assigned this May 20, 2025
@danielfeismann danielfeismann added the bug Something isn't working label May 20, 2025
@danielfeismann danielfeismann mentioned this pull request May 21, 2025
Open
@danielfeismann
Merge branch 'dev' into df/#1391-hp-flex-behaviour
bab54f4 
# Conflicts:
#	src/main/scala/edu/ie3/simona/model/participant/HpModel.scala
#	src/main/scala/edu/ie3/simona/model/thermal/CylindricalThermalStorage.scala
#	src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala
#	src/test/scala/edu/ie3/simona/agent/em/EmAgentIT.scala
#	src/test/scala/edu/ie3/simona/agent/grid/ThermalGridIT.scala
@danielfeismann danielfeismann marked this pull request as ready for review May 22, 2025 13:01
staudtMarius
staudtMarius requested changes Jun 24, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just have one small question regarding new the determination of the ref power.

@staudtMarius staudtMarius self-requested a review June 25, 2025 09:49
staudtMarius
staudtMarius previously approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @sebastian-peter if you don't have any objections, this PR can be merged.

@danielfeismann
Merge branch 'dev' into df/#1391-hp-flex-behaviour
7d847af 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/model/participant/hp/HpModel.scala
@danielfeismann
adapt to changes in dev
1480b84
danielfeismann added a commit that referenced this pull request Jul 30, 2025
@danielfeismann
fix after merging dev and #1392
6c07039
@danielfeismann danielfeismann added this to the Version 4.1 milestone Aug 7, 2025
sebastian-peter
sebastian-peter reviewed Sep 10, 2025
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment from my side

@danielfeismann
Merge branch 'dev' into df/#1391-hp-flex-behaviour
6d2107d 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/model/participant/hp/HpPowerLimitFlexModel.scala
@danielfeismann
improving after reviewer feedback
8468e11
@danielfeismann
more refactoring
d296c98
@sebastian-peter sebastian-peter merged commit 42dd982 into dev Sep 16, 2025
4 checks passed
@sebastian-peter sebastian-peter deleted the df/#1391-hp-flex-behaviour branch September 16, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@staudtMarius staudtMarius staudtMarius left review comments

Assignees

@danielfeismann danielfeismann

Labels

bug Something isn't working

Projects

None yet

Milestone

Version 4.1

Development

Successfully merging this pull request may close these issues.

Adapt ThermalHouse and HP flexibility behaviour

4 participants

@danielfeismann @sebastian-peter @staudtMarius