Skip to content

Conversation

jo-bao
Copy link
Contributor

@jo-bao jo-bao commented Apr 17, 2023

Resolves #768

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Apr 18, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/794.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/794.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@jo-bao
Copy link
Contributor Author

jo-bao commented Apr 18, 2023

!test

@jo-bao jo-bao marked this pull request as ready for review April 18, 2023 12:35
@jo-bao jo-bao self-assigned this Apr 18, 2023
@t-ober t-ober self-assigned this Apr 19, 2023
@jo-bao jo-bao requested a review from t-ober April 21, 2023 11:27
@jo-bao
Copy link
Contributor Author

jo-bao commented Apr 25, 2023

!test

Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good! Just one minor thing

@jo-bao jo-bao requested a review from t-ober May 4, 2023 15:23
@t-ober t-ober merged commit 5755f74 into dev May 5, 2023
@t-ober t-ober deleted the jb/#768-hierarchic-grids branch May 5, 2023 05:23
@sebastian-peter sebastian-peter added this to the Version 4.0 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JointGridContainerSource should be able to read hierarchic grids
4 participants