Skip to content

Use net46 as the target framework for windows tests #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piksel merged 2 commits into from
Mar 14, 2021
Merged

Use net46 as the target framework for windows tests #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d702f11
use net46 for windows testing on push
piksel Mar 14, 2021
3b30a02
use net46 for windows testing for PRs
piksel Mar 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/on-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ jobs:
- configuration: debug
os: windows
libtarget: net45
testtarget: net45
testtarget: net46
- configuration: release
os: windows
libtarget: net45
testtarget: net45
testtarget: net46
steps:
- uses: actions/checkout@v2

Expand Down
14 changes: 3 additions & 11 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,7 @@ jobs:
os: [ubuntu, windows, macos]
target: [netstandard2.0, netstandard2.1]
include:
- configuration: Debug
os: windows
target: net45
- configuration: Release
os: windows
- os: windows
target: net45
steps:
- uses: actions/checkout@v2
Expand All @@ -41,12 +37,8 @@ jobs:
os: [ubuntu, windows, macos]
target: [netcoreapp3.1]
include:
- configuration: debug
os: windows
target: net45
- configuration: release
os: windows
target: net45
- os: windows
target: net46
steps:
- uses: actions/checkout@v2

Expand Down