-
Notifications
You must be signed in to change notification settings - Fork 1k
Implement ReadAsync in ZipAESStream, extra simple version #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@piksel Any thoughts on applying the simple approach as a quick fix for for #572, given that I don't think a 'full' async version would actually do async reads at this point unless PartialInputStream was made async as well (ref #589)? (It'd be nicer to make everything more fully async, not sure if there's any thoughts of a timespan for a next maintenance release vs. doign that though) |
|
Yeah, I agree. Having the "stub" async override in the code base until another way is implemented is definitively better than trying to solve this correctly before doing anything. |
b3ce045 to
ace6983
Compare
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 70.96% 73.05% +2.08%
==========================================
Files 68 68
Lines 13417 8724 -4693
==========================================
- Hits 9522 6373 -3149
+ Misses 3895 2351 -1544
Continue to review full report at Codecov.
|
ace6983 to
525555e
Compare
Possible extra trivial version of #576, just for testing and a potential quick fix (whereby it doesn't attempt to actually be async)
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.