Skip to content

Merge CIP code #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2019
Merged

Merge CIP code #313

merged 1 commit into from
May 16, 2019

Conversation

@sdmarshall79
Copy link
Contributor

@sdmarshall79 sdmarshall79 commented May 13, 2019

No description provided.

@sdmarshall79 sdmarshall79 requested a review from arthurbarr May 13, 2019 15:51
@parrobe
Copy link
Member

parrobe commented May 15, 2019

I've just noticed a couple of errors in the Makefile that could be corrected as part of this. Will need to double check with Arthur though:

  1. Line 166, no .PHONY for coverage target
  2. Line 267, target does not match .PHONY definition on line above
  3. Line 285, target does not match .PHONY definition on line above

@arthurbarr arthurbarr merged commit c079c1b into ibm-messaging:master May 16, 2019
@sdmarshall79 sdmarshall79 deleted the cip-merge branch May 30, 2019 12:51
mirskifa added a commit that referenced this pull request Aug 31, 2022
@mirskifa
Merge pull request #313 from mq-cloudpak/amf-credential-helper-go-ver…
8ba8ae4 
…sion-930

Pin docker-credential-helpers for old go installs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthurbarr arthurbarr arthurbarr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdmarshall79 @parrobe @arthurbarr