IBX-10555: Added blurred loader for modal #1757
Conversation
OstafinL
force-pushed
the
IBX-10555-added-blured-loader-for-modal
branch
from
9a9e304 to
ac95ed9
Compare
OstafinL
force-pushed
the
IBX-10555-added-blured-loader-for-modal
branch
3 times, most recently
from
bc2866a to
b2f4d20
Compare
OstafinL
changed the title
ezrobot
requested review from
GrabowskiM,
RopRaptor,
albozek,
alekmick,
dew326 and
tischsoic
and removed request for
a team
| }; | ||
|
|
||
| export { controlZIndex, controlManyZIndexes }; | ||
| const showModalLoader = ({ headerText, descriptionText, modalNode }) => { |
There was a problem hiding this comment.
personally I would put modalNode as its own method argument, as it's THE element which is mandatory for it to even work?
Same with hideModalLoader (there it would be even more useful, as there would be no need to pass object just to pass one argument
| &__loader-header-text { | ||
| } | ||
|
|
There was a problem hiding this comment.
| &__loader-header-text { | |
| } |
| &__loader-header-text { | ||
| } |
There was a problem hiding this comment.
| &__loader-header-text { | |
| } |
| modalNode.classList.remove('ibexa-modal--with-blurred-loader'); | ||
| }; | ||
|
|
||
| document.body.addEventListener('hidden.bs.modal', (event) => { |
There was a problem hiding this comment.
Own concern.
Seems like this might affect ALL modals on the page - is that intended?
There was a problem hiding this comment.
I think it is intentional, but it should have checked if the modal was blurred and unsage of helper should be in different place, not in helper itself because we can have helper imported multiple time on the page which can cause some errors.
| modalNode.classList.remove('ibexa-modal--with-blurred-loader'); | ||
| }; | ||
|
|
||
| document.body.addEventListener('hidden.bs.modal', (event) => { |
There was a problem hiding this comment.
I think it is intentional, but it should have checked if the modal was blurred and unsage of helper should be in different place, not in helper itself because we can have helper imported multiple time on the page which can cause some errors.
juskora
force-pushed
the
IBX-10555-added-blured-loader-for-modal
branch
from
b930c36 to
4476813
Compare
|
The text in the second line should be divided into two lines, following the design |
juskora
force-pushed
the
IBX-10555-added-blured-loader-for-modal
branch
from
70844c8 to
88df1bf
Compare
|
|
QA Approved on Ibexa DXP Commerce 4.6-dev. |
9 participants
Description:
Figma: https://www.figma.com/design/kUj5EQzhDotuXIbbhcvRPA/-Content--Share-link-of-content-%E2%80%A8--collaborative-editing?node-id=10035-188564&t=K37yRrSfAFkGFOTB-0
Screenshot with changes:
For QA:
Documentation: