IBX-10186: Port forward patch leveraging new count limits #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanolee
force-pushed
the
feature/IBX-10186
branch
from
52313f7 to
196ccb2
Compare
|
ryanolee
changed the title
adamwojs
changed the title
Steveb-p
reviewed
Nov 12, 2025
Contributor
Steveb-p
left a comment
Steveb-p
left a comment
There was a problem hiding this comment.
Just general remarks from my based on what I see. It's possible some things are not possible to be achieved.
|
|
||
| return new UIValue\Content\Location($location, [ | ||
| 'childCount' => $this->locationService->getLocationChildCount($location), | ||
| 'childCount' => $this->locationService->getLocationChildCount($location, $useLimit ? $limit + 1 : null), |
Contributor
There was a problem hiding this comment.
We should be able to establish at this point that current Location child count exceeds the limit, maybe?
I'd prefer to set this value to null indicating that we aren't able to determine the amount if possible.
| $childCount = $this->locationService->getLocationChildCount($location); | ||
| $limit = $this->configResolver->getParameter('subtree_operations.query_subtree.limit'); | ||
|
|
||
| $useLimit = $limit > 0; |
Contributor
There was a problem hiding this comment.
Ideally we would be more specific, and use null value to indicate limitless queries - and treat non-positive/null values in parameter as an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Depends on
Description:
This PR is a forward facing port of ezsystems/ezplatform-admin-ui#2125. Please read that PR to understand what this one is aiming to do. Though the general idea is to leverage changes made in ezsystems/ezplatform-admin-ui#2125 throughout the admin to make it significantly more scalable when large number of sub items sit under singular content objects.
Visually as little as possible changes. The only noticeable change is that when a count limit is exceeded the count will render with a + at the end
What has changed / Why
To hold off on repeating ezsystems/ezplatform-admin-ui#2125 as all reasons remain the same if the implementation is a little different
For QA:
ibexa.site_access.config.admin_group.subtree_operations.query_subtree.limit: 1^ Set this parameter to 1
Checkout this branch and and ibexa/core#600
Navigate the admin and check general functionality remains the same.
If able to test in an environment with a large number of content objects 500,000 plus verify that performance is generally observed to be better. (See benchmarks from other PR: ezsystems/ezplatform-admin-ui#2125)
Testing