i3-4.10.2/src/workspace.c:131: possible bad if ?

[dcb314]

[../i3-4.10.2/src/workspace.c:131]: (warning) Char literal compared with pointer 'target'. Did you intend to dereference it?

while ((*target == ' ' || *target == '\t') && target != '\0')

Maybe

while ((*target == ' ' || *target == '\t') && *target != '\0')

[i3bot]

I don’t see a link to logs.i3wm.org. Did you follow http://i3wm.org/docs/debugging.html? (In case you actually provided a link to a logfile, please ignore me.)

[i3bot]

I don’t see a version number. Could you please copy & paste the output of i3 --version into this issue?

[dcb314]

I don’t see a version number

Doh. File with the problem is ../i3-4.10.2/src/workspace.c. Guess.

[Airblader]

The way I see it the check for \0 is redundant anyway. If *target is \0, then the other condition is false anyway.

[Airblader]

Thanks for the report!