feat: table add/remove columns

[jake-bassett]

No description provided.

[codecov]

Codecov Report

Merging #333 (b1e583d) into main (09f2234) will decrease coverage by 0.00%.
The diff coverage is 78.70%.

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   86.24%   86.23%   -0.01%     
==========================================
  Files         723      725       +2     
  Lines       14733    14807      +74     
  Branches     1881     1760     -121     
==========================================
+ Hits        12706    12769      +63     
- Misses       1995     2007      +12     
+ Partials       32       31       -1     

Impacted Files	Coverage Δ
projects/components/src/modal/modal.ts	100.00% <ø> (ø)
...hared/graphql/model/metadata/attribute-metadata.ts	100.00% <ø> (+50.00%)	⬆️
.../handler/metadata-graphql-query-handler.service.ts	100.00% <ø> (ø)
...y/src/pages/explorer/explorer-dashboard-builder.ts	88.88% <ø> (ø)
...lore-query-editor/explore-visualization-builder.ts	97.77% <0.00%> (ø)
...able/columns/table-edit-columns-modal.component.ts	25.00% <25.00%> (ø)
...ble/header/table-header-cell-renderer.component.ts	73.52% <40.00%> (-5.79%)	⬇️
projects/components/src/table/table.component.ts	91.50% <86.95%> (-0.36%)	⬇️
...ared/dashboard/widgets/table/table-widget.model.ts	81.57% <88.88%> (+0.93%)	⬆️
...ets/table/services/table-widget-columns.service.ts	92.10% <92.10%> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f2234...b1e583d. Read the comment docs.

[aaron-steinfeld]

In what cases do we not want this? I'd assume to be implicit in whether we provide a scope or not - it's easier to add an explicit property later than to remove one.

[jake-bassett]

Edit columns comes with two modes. The first mode only uses the columns specified in the json. The second mode also fetches attributes and turns those into columns.

This property is to enable the second mode. The scope is hard coded in the data model and always present so we can't use that as a way to enable this mode.

[aaron-steinfeld]

So the assumption I built into my statement may not hold - I assumed, if a data source was used that supported attributes (as determined by the presence of a scope), we'd always want this. If we want to selectively enable, then makes sense.

[jake-bassett]

Correct. In fact testing the attribute fetching mode, I'm finding issues with some attributes that can't be fetched. Going to have to work on those case by case, but it looks like using the json defined mode will be the typical case in the near term while we iron out the wrinkles with the troublesome attributes.