-
Notifications
You must be signed in to change notification settings - Fork 7
add creation and last updated timestamps #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SrikarMannepalli
merged 5 commits into
main
from
add-creation-and-lastUpdated-timestamps-for-excludeSpanRules
Feb 25, 2022
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5020b90
add creation and last updated timestamps
SrikarMannepalli 4fccf6a
Merge branch 'main' into add-creation-and-lastUpdated-timestamps-for-…
SrikarMannepalli 6dfd0e0
address review comments
SrikarMannepalli 21981df
Merge branch 'main' into add-creation-and-lastUpdated-timestamps-for-…
SrikarMannepalli 537b700
add disabled
SrikarMannepalli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 0 additions & 40 deletions
40
...a/org/hypertrace/graphql/spanprocessing/dao/ConfigServiceSpanProcessingRuleConverter.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
...ypertrace/graphql/spanprocessing/dao/ConfigServiceSpanProcessingRuleDetailsConverter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| package org.hypertrace.graphql.spanprocessing.dao; | ||
|
|
||
| import io.reactivex.rxjava3.core.Single; | ||
| import java.time.Instant; | ||
| import javax.inject.Inject; | ||
| import lombok.Value; | ||
| import lombok.experimental.Accessors; | ||
| import org.hypertrace.core.graphql.common.utils.Converter; | ||
| import org.hypertrace.graphql.spanprocessing.schema.rule.ExcludeSpanRuleDetails; | ||
| import org.hypertrace.graphql.spanprocessing.schema.rule.filter.SpanProcessingRuleFilter; | ||
|
|
||
| class ConfigServiceSpanProcessingRuleDetailsConverter | ||
| implements Converter< | ||
| org.hypertrace.span.processing.config.service.v1.ExcludeSpanRuleDetails, | ||
| ExcludeSpanRuleDetails> { | ||
|
|
||
| private final ConfigServiceSpanFilterConverter filterConverter; | ||
|
|
||
| @Inject | ||
| ConfigServiceSpanProcessingRuleDetailsConverter( | ||
| ConfigServiceSpanFilterConverter filterConverter) { | ||
| this.filterConverter = filterConverter; | ||
| } | ||
|
|
||
| @Override | ||
| public Single<ExcludeSpanRuleDetails> convert( | ||
| org.hypertrace.span.processing.config.service.v1.ExcludeSpanRuleDetails ruleDetails) { | ||
| return this.filterConverter | ||
| .convert(ruleDetails.getRule().getRuleInfo().getFilter()) | ||
| .map( | ||
| spanProcessingRuleFilter -> | ||
| new ConvertedExcludeSpanRuleDetails( | ||
| ruleDetails.getRule().getId(), | ||
| ruleDetails.getRule().getRuleInfo().getName(), | ||
| spanProcessingRuleFilter, | ||
| Instant.ofEpochSecond( | ||
| ruleDetails.getMetadata().getCreationTimestamp().getSeconds(), | ||
| ruleDetails.getMetadata().getCreationTimestamp().getNanos()), | ||
| Instant.ofEpochSecond( | ||
| ruleDetails.getMetadata().getLastUpdatedTimestamp().getSeconds(), | ||
| ruleDetails.getMetadata().getLastUpdatedTimestamp().getNanos()))); | ||
| } | ||
|
|
||
| @Value | ||
| @Accessors(fluent = true) | ||
| private static class ConvertedExcludeSpanRuleDetails implements ExcludeSpanRuleDetails { | ||
| String id; | ||
| String name; | ||
| SpanProcessingRuleFilter spanFilter; | ||
| Instant creationTime; | ||
| Instant lastUpdatedTime; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...c/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRuleDetails.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package org.hypertrace.graphql.spanprocessing.schema.rule; | ||
|
|
||
| import graphql.annotations.annotationTypes.GraphQLName; | ||
|
|
||
| @GraphQLName(ExcludeSpanRuleDetails.TYPE_NAME) | ||
| public interface ExcludeSpanRuleDetails extends ExcludeSpanRule, ExcludeSpanRuleMetadata { | ||
| String TYPE_NAME = "ExcludeSpanRuleDetails"; | ||
| } | ||
24 changes: 24 additions & 0 deletions
24
.../main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRuleMetadata.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package org.hypertrace.graphql.spanprocessing.schema.rule; | ||
|
|
||
| import graphql.annotations.annotationTypes.GraphQLField; | ||
| import graphql.annotations.annotationTypes.GraphQLName; | ||
| import graphql.annotations.annotationTypes.GraphQLNonNull; | ||
| import java.time.Instant; | ||
|
|
||
| @GraphQLName(ExcludeSpanRuleMetadata.TYPE_NAME) | ||
| public interface ExcludeSpanRuleMetadata { | ||
| String TYPE_NAME = "ExcludeSpanRuleMetadata"; | ||
|
|
||
| String CREATION_TIME_KEY = "creationTime"; | ||
| String LAST_UPDATED_TIME_KEY = "lastUpdatedTime"; | ||
|
|
||
| @GraphQLField | ||
| @GraphQLName(CREATION_TIME_KEY) | ||
| @GraphQLNonNull | ||
| Instant creationTime(); | ||
|
|
||
| @GraphQLField | ||
| @GraphQLName(LAST_UPDATED_TIME_KEY) | ||
| @GraphQLNonNull | ||
| Instant lastUpdatedTime(); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.