Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

Description

Remove config filter for graphql - not needed here. It was an optimization (and avoided enforcing extra strict checks on test deps), but looks like snyk requires it match every project. Because graphql uses a platform project (which apparently snyk doesn't have built in support for) it has a project that does not have its own runtimeClasspath.

I also tried changing the regex to make it less strict, but even something like runtime or .*runtime.* is not matching:

> Matching configurations not found: runtime, available configurations for project project ':hypertrace-core-graphql-platform': [api, apiElements, archives, classpath, default, enforcedApiElements, enforcedRu
ntimeElements, runtime, runtimeElements]

Testing

Ran snyk locally successfully

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #41 (a16fb3e) into main (d251177) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #41   +/-   ##
=========================================
  Coverage     61.65%   61.65%           
  Complexity      227      227           
=========================================
  Files            76       76           
  Lines          1137     1137           
  Branches         29       29           
=========================================
  Hits            701      701           
  Misses          412      412           
  Partials         24       24           
Flag Coverage Δ Complexity Δ
unit 61.65% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d251177...a16fb3e. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit 095b466 into main Jan 7, 2021
@aaron-steinfeld aaron-steinfeld deleted the remove-config-match branch January 7, 2021 03:13
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

Unit Test Results

27 files  ±0  27 suites  ±0   33s ⏱️ ±0s
94 tests ±0  94 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 095b466. ± Comparison against base commit d251177.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants