Skip to content

Conversation

@piotrostr
Copy link

@piotrostr piotrostr commented May 27, 2025

This change allows to use other signer types, like remote signers, or secure envelope providers (Privy, Magic, etc) for the Secp256k1 signatures

There is minimal migrational overhead, the trait is implemented in signer/mod.rs for the LocalWallet, only requires wrapping it with atomic reference counter (Arc) due to dynamic object size of the struct implementing the trait

This could be extended with KMS like Hashicorp Vault etc, in our use-case it comes down to enabling Privy

This change also adds serde::Serialize for the InfoClient types for better composability

@piotrostr piotrostr changed the title feat: add serialize trait to info structs feat: accept signer trait impl instead of LocalWallet (remote signers, secure envelope providers) Jun 2, 2025
@piotrostr piotrostr changed the title feat: accept signer trait impl instead of LocalWallet (remote signers, secure envelope providers) feat: accept signer trait impl instead of LocalWallet Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant