Clarifying Signature Policy selection #1578
Conversation
There was a problem hiding this comment.
Hi ruffsl, Thanks for your contribution. For commit message we follow the rules in the contributor guide here: https://sawtooth.hyperledger.org/docs/core/releases/latest/community/contributing.html and this: https://chris.beams.io/posts/git-commit/#seven-rules
Could you update your commit messages and add a dco sign off as well.
| @@ -153,7 +153,8 @@ Instructions for creating your own service provider certificate can be found | |||
| After your certificate is created you'll need to register it with the | |||
| attestation service. | |||
| `Click here <https://software.intel.com/formfill/sgx-onboarding>`_ for the | |||
| registration form. | |||
| registration form. Remeber to select ``Linkable`` when choosing the Attestation policy given that PoET relyes on "Linkable" EPID signatures. This means the device will always present a consistent identity within the Attestation service. Further details on Signature Policy can be found | |||
There was a problem hiding this comment.
"relies" is misspelled as "relyes"
There was a problem hiding this comment.
"Remember" is misspelled as "Remeber".
There was a problem hiding this comment.
Suggestion: "Please select Linkable option when" would read better in lieu of "Remember to select Linkable when"
There was a problem hiding this comment.
"since" would be a better alternative for the "given that" in the text
ruffsl
force-pushed
the
patch-1
branch
2 times, most recently
from
3ed3138 to
60411b4
Compare
|
@askmish please let me know if more changes are needed. |
|
@ruffsl looks good. Could you please just rebase the commit? We had some CI changes and this won't pass until your branch lays ontop of those changes. Will be something like... |
Selection of Signature Policy during submission of a Development Services Access Request should be clarified to ensure users chose the Linkable quote option, as it is necessary since PoET relies on Linkable EPID signatures. Signed-off-by: ruffsl <[email protected]>
|
@dcmiddle , thanks for the instructions. PR branch now rebased on to upstream master. |
|
Hello, it looks like this commit introduced an error in the build system. |
when submitting a Development Services Access Request to Intel.