Skip to content

Add a safe way to fill a ReadBuf #3515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a safe way to fill a ReadBuf #3515

wants to merge 2 commits into from

Conversation

notgull
Copy link

@notgull notgull commented Jan 5, 2024

Closes #3509

notgull added 2 commits January 5, 2024 07:00
@notgull
Add a safe way to fill a ReadBuf
84d0e83 
Closes hyperium#3509

Signed-off-by: John Nunley <[email protected]>
@notgull
Add test
3cf4d5f 
Signed-off-by: John Nunley <[email protected]>
@seanmonstar
Copy link
Member

Thanks for the PR!

My initial thoughts were that we could provide a couple methods like in BorrowedCursor. Looking through them, it occurs to me that the only "basic" safe way to write data is to like append(&[u8]). Otherwise, even if you can safely access all initialized_mut(), it would still be unsafe to state an arbitrary number of bytes have been written.

@seanmonstar seanmonstar added the S-waiting-on-author Status: waiting on the author to provide more info, or make changes. label Jan 31, 2024
@notgull
Copy link
Author

notgull commented May 30, 2024

My initial thoughts were that we could provide a couple methods like in BorrowedCursor.

Any specific methods?

@nox nox mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: waiting on the author to provide more info, or make changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to safely read into ReadBuf
2 participants
@notgull @seanmonstar