Skip to content

Simplify window_size_decremented_past_zero #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Simplify window_size_decremented_past_zero #829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 11 additions & 106 deletions tests/h2-tests/tests/flow_control.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1864,122 +1864,27 @@ async fn window_size_decremented_past_zero() {
let (io, mut client) = mock::new();

let client = async move {
// let _ = client.assert_server_handshake().await;
let settings = client.assert_server_handshake().await;
assert_default_settings!(settings);

// preface
client.write_preface().await;
// Invalid HEADERS frame (missing mandatory fields).
client.send_bytes(&[0, 0, 0, 1, 5, 0, 0, 0, 1]).await;

// the following http 2 bytes are fuzzer-generated
client.send_bytes(&[0, 0, 0, 4, 0, 0, 0, 0, 0]).await;
client
.send_bytes(&[
0, 0, 23, 1, 1, 0, 249, 255, 191, 131, 1, 1, 1, 70, 1, 1, 1, 1, 65, 1, 1, 65, 1, 1,
65, 1, 1, 1, 1, 1, 1, 190,
])
.await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client
.send_bytes(&[
0, 0, 9, 247, 0, 121, 255, 255, 184, 1, 65, 1, 1, 1, 1, 1, 1, 190,
])
.await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client
.send_bytes(&[0, 0, 3, 0, 1, 0, 249, 255, 191, 1, 1, 190])
.await;
client
.send_bytes(&[0, 0, 2, 50, 107, 0, 0, 0, 1, 0, 0])
.await;
client
.send_bytes(&[0, 0, 5, 2, 0, 0, 0, 0, 1, 128, 0, 55, 0, 0])
.await;
client
.send_bytes(&[
0, 0, 12, 4, 0, 0, 0, 0, 0, 126, 4, 39, 184, 171, 125, 33, 0, 3, 107, 50, 98,
])
.await;
client
.send_bytes(&[0, 0, 6, 4, 0, 0, 0, 0, 0, 3, 4, 76, 255, 71, 131])
.await;
client
.send_bytes(&[
0, 0, 12, 4, 0, 0, 0, 0, 0, 0, 4, 39, 184, 171, 74, 33, 0, 3, 107, 50, 98,
])
.await;
client
.send_bytes(&[
0, 0, 30, 4, 0, 0, 0, 0, 0, 0, 4, 56, 184, 171, 125, 65, 0, 35, 65, 65, 65, 61,
232, 87, 115, 89, 116, 0, 4, 0, 58, 33, 125, 33, 79, 3, 107, 49, 98,
])
.await;
client
.send_bytes(&[
0, 0, 12, 4, 0, 0, 0, 0, 0, 0, 4, 39, 184, 171, 125, 33, 0, 3, 107, 50, 98,
])
.await;
client.send_bytes(&[0, 0, 0, 4, 0, 0, 0, 0, 0]).await;
client
.send_bytes(&[
0, 0, 12, 4, 0, 0, 0, 0, 0, 126, 4, 39, 184, 171, 125, 33, 0, 3, 107, 50, 98,
])
.await;
client
.send_bytes(&[
0, 0, 177, 1, 44, 0, 0, 0, 1, 67, 67, 67, 67, 67, 67, 131, 134, 5, 61, 67, 67, 67,
67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67,
67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67,
67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 115, 102, 1, 3, 48, 43,
101, 64, 31, 37, 99, 99, 97, 97, 97, 97, 49, 97, 54, 97, 97, 97, 97, 49, 97, 54,
97, 99, 54, 53, 53, 51, 53, 99, 99, 97, 97, 99, 97, 97, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0,
])
.await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client
.send_bytes(&[
0, 0, 12, 4, 0, 0, 0, 0, 0, 0, 4, 0, 58, 171, 125, 33, 79, 3, 107, 49, 98,
])
.await;
client
.send_bytes(&[0, 0, 6, 4, 0, 0, 0, 0, 0, 0, 4, 87, 115, 89, 116])
.send_frame(frames::settings().initial_window_size(1329018135))
.await;

client
.send_bytes(&[
0, 0, 12, 4, 0, 0, 0, 0, 0, 126, 4, 39, 184, 171, 125, 33, 0, 3, 107, 50, 98,
])
.send_frame(frames::settings().initial_window_size(3809661))
.await;

client
.send_bytes(&[
0, 0, 129, 1, 44, 0, 0, 0, 1, 67, 67, 67, 67, 67, 67, 131, 134, 5, 18, 67, 67, 61,
67, 67, 67, 67, 67, 67, 67, 67, 67, 67, 48, 54, 53, 55, 114, 1, 4, 97, 49, 51, 116,
64, 2, 117, 115, 4, 103, 101, 110, 116, 64, 8, 57, 111, 110, 116, 101, 110, 115,
102, 7, 43, 43, 49, 48, 48, 43, 101, 192, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
])
.send_frame(frames::settings().initial_window_size(1467177332))
.await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;
client.send_bytes(&[0, 0, 0, 0, 0, 0, 0, 0, 1]).await;

client
.send_bytes(&[
0, 0, 12, 4, 0, 0, 0, 0, 0, 0, 4, 0, 58, 171, 125, 33, 79, 3, 107, 49, 98,
])
.send_frame(frames::settings().initial_window_size(3844989))
.await;

// TODO: is CANCEL the right error code to expect here?
// client.recv_frame(frames::reset(1).protocol_error()).await;
};

let srv = async move {
Expand Down
Loading