-
-
Notifications
You must be signed in to change notification settings - Fork 406
Refactor Hyperion JSON-API #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @dermotduffy this PR should address some shortcomings you identified before. For easy PR testing see here |
|
@Lord-Grey I assume you are referring to issues like this, where Hyperion goes unavailable but Home Assistant doesn't notice. A PR as described here might help, at least in cases of a "clean shutdown". I think we'll still have the broken state when the plug is pulled on Hyperion (i.e. when Hyperion cannot call the callback): home-assistant/core#98674 (comment) On that issue, @ToniCipriani was interested in working on it and might like to test with this. A simple way to improve the situation, after this PR is submitting, would be to subscribe to the new events and have the HA integration mark the entities as unavailable when the callback happens. |
This fixes hyperion-project#1936. It's probably a regression introduced by hyperion-project#1727
Summary
Breaking
ledcolors-imagestream-update, ledcolors-ledstream-update, logmsg-updatenow return data viadataand notresultAdded
Suspend, Resume, Idle, idleResume, Restart, Quit.serverinfosubcommands:getInfo, subscribe, unsubscribe, getSubscriptions, getSubscriptionCommandsChanged
Removed
authorize-adminRequiredwill always betrue.session-updatessubscriptionserverinfo/subscribeelement will be deprecated and replaced by corresponding subcommandWhat kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
Clients using the JSON API need to process the
dataand notresultelement onledcolors-imagestream-update, ledcolors-ledstream-update.The PR fulfills these requirements:
Fixes: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
fixes #809