Skip to content

Conversation

@tuxuser
Copy link
Contributor

@tuxuser tuxuser commented Jul 23, 2022

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Ensures reproducible builds (see f.e. Mbed-TLS/mbedtls#6124)

@hyperion-project
Copy link

Hello @tuxuser 👋

I'm the Hyperion Project Bot and I want to thank you for
contributing to Hyperion with your pull requests!

To help you and other users test your pull requests faster,
I'll create a link for you to your workflow artifacts.

🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/2725268894

Of course, if you make changes to your PR, I will create a new link.

Best regards,
Hyperion Project

@Lord-Grey
Copy link
Collaborator

@tuxuser Would you mind to update dependencies/CMAKELIST too, please?

See 6f0ccdb for reference.

@hyperion-project
Copy link

Hey @tuxuser I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/2728147020

@tuxuser
Copy link
Contributor Author

tuxuser commented Jul 24, 2022

Done.

  • Also pinned mbedtls version in dependencies/CMakeLists.txt
  • Added comment as seen in 6f0ccdb, with the opposite narrative though.

Update: thx for correcting the typo.

Remove extra space
@hyperion-project
Copy link

Hey @tuxuser I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/2728243451

@Lord-Grey
Copy link
Collaborator

@tuxuser Thank you!

@Lord-Grey Lord-Grey merged commit abde114 into hyperion-project:master Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants