Skip to content

Conversation

@Lord-Grey
Copy link
Collaborator

@Lord-Grey Lord-Grey commented Oct 20, 2021

Summary

  • Fixes APA102 protocol aligning to the standard defined
    (using low values rather high values at the end frame, plus aligning color mapping as defined per standard)

Additional

  • New: Support setting maximum brightness level (1-31)
  • Removed: Latch-Time as not required by APA102 protocol

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
Fixes #1352, #1132

@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm the Hyperion Project Bot and I want to thank you for
contributing to Hyperion with your pull requests!

To help you and other users test your pull requests faster,
I'll create a link for you to your workflow artifacts.

🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1364106977

Of course, if you make changes to your PR, I will create a new link.

Best regards,
Hyperion Project

@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1364106977

@Lord-Grey Lord-Grey merged commit 954112a into hyperion-project:master Oct 28, 2021
@Lord-Grey Lord-Grey deleted the Fix_#1352 branch November 20, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LEDs do not turn off when LED Output is turned off

2 participants