Test failure in Sentry 7.73.0

[joshkel]

The latest Sentry update (version 7.73.0) causes the 'allows deactivating capture (opts.dsn to be false)' test to fail.

This is a result of getsentry/sentry-javascript#9101 (which was added in order to support local processing of Sentry events, even if no transport / no DSN is configured).

I believe the test can simply be deleted (I believe it's safe to trust Sentry's behavior here), but I could be wrong.

[fiws]

sounds like setting it to "undefined" should work?

[joshkel]

@fiws , I'm not sure if that will work as intended:

Based on the README's documentation of client, I assumed that the opts.client.dsn !== undefined check is intended to distinguish between "an already initialized Sentry client" and "a Sentry client options object."

If the dsn is undefined, then hapi-sentry skips initializing Sentry completely. However, from skimming the rest of the hapi-sentry plugin, it looks like it assumes that Sentry is initialized.

[fiws]

fixed with 07eaac6

test was adjusted to just test that "false" can still be passed